Ala Hino has posted comments on this change.

Change subject: qemuimg: Expose API for qemuimg map
......................................................................


Patch Set 4:

(4 comments)

https://gerrit.ovirt.org/#/c/65112/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:

Line 497:             # Empty run
Line 498:             run = img_map[2]
Line 499:             self.assertEqual(run["length"], size - offset - length)
Line 500:             self.assertEqual(run["data"], False)
Line 501:             self.assertEqual(run["zero"], True)
> Please use the same style as in the qcow2 test for verifying.
Done
Line 502: 
Line 503:     @permutations([
Line 504:         # offset, length, expected_length, expected_start, 
qcow2_compat
Line 505:         (64 * 1024, 4 * 1024, 65536, 131072, "0.10"),


Line 530:                 },
Line 531:                 # run 2 - data
Line 532:                 {
Line 533:                     "start": offset,
Line 534:                     "offset": 327680,
> Do you have a clue about this value?
No idea :(
Line 535:                     "length": expected_length,
Line 536:                     "data": True,
Line 537:                     "zero": False,
Line 538:                 },


Line 537:                     "zero": False,
Line 538:                 },
Line 539:                 # run 3 - empty
Line 540:                 {
Line 541:                     "start": expected_start,
> Isn't this offset + expected_length?
Fixed
Line 542:                     "length": size - offset - expected_length,
Line 543:                     "data": False,
Line 544:                     "zero": True,
Line 545:                 },


Line 540:                 {
Line 541:                     "start": expected_start,
Line 542:                     "length": size - offset - expected_length,
Line 543:                     "data": False,
Line 544:                     "zero": True,
> Do we have an offsect in this run? what is the value?
No offset here
Line 545:                 },
Line 546:             ]
Line 547: 
Line 548:             for actual, expected in zip(img_map, expected):


-- 
To view, visit https://gerrit.ovirt.org/65112
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54d6c936239d3dcc7a3d236dbaab0a93501ada8c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to