Nir Soffer has posted comments on this change.

Change subject: tests: Use Popen.poll() for running state
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/65323/4//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2016-10-13 03:07:01 +0300
Line 6: 
Line 7: tests: Use Popen.poll() for running state
Line 8: 
Line 9: Checking if /proc/pid exists works, but using poll() is simpler and more
> `exits` should be enough or we could use `exists/works`
Currently we check if /proc/pid exists, this checks works but we can use 
Popen.poll() instead. I son't see how I can remove the word "works" or how 
"exists/works" is corect.
Line 10: clear.
Line 11: 
Line 12: Since proc_path is used only in one test, move it the test using it.
Line 13: 


-- 
To view, visit https://gerrit.ovirt.org/65323
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I086e9317b5f8e5324d86bedeb04b485c7a09ad16
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to