Nir Soffer has posted comments on this change.

Change subject: utils: Raise detectable error if termination fail
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/65325/5//COMMIT_MSG
Commit Message:

Line 14: job running the process must stay in running state to prevent engine
Line 15: from starting the same operation on another machine.
Line 16: 
Line 17: Typically when we cannot handle an error we should not handle it. But
Line 18: in this special case, letting the caller handle the error is not useful
> handling the error without knowing the context (pid) is not useful. That is
Trying to make it more clear in the next version.
Line 19: since it does not have any context.
Line 20: 
Line 21: To make it possible to handle this critical error, we raise now a new
Line 22: TerminatingFallure exception with process pid and the original error.


-- 
To view, visit https://gerrit.ovirt.org/65325
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5cfa5434ce011b9185550884233b5b233026d13c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to