Piotr Kliczewski has posted comments on this change.

Change subject: tests: Add tests for poll and wait failures
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/65294/8/tests/utilsTests.py
File tests/utilsTests.py:

Line 132:         self.check_failure()
Line 133: 
Line 134:     def test_kill_failure(self):
Line 135:         def fail():
Line 136:             raise ExpectedFailure("Fake kill failure")
> 3 test, 3 fail texts, please suggest a simple and more clear code.
Why not to have fail method as top level and use it 138 and in 145 line. We do 
not need to have it in two places.
Line 137: 
Line 138:         self.proc.kill = fail
Line 139:         self.check_failure()
Line 140: 


-- 
To view, visit https://gerrit.ovirt.org/65294
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8674c9c3c2118041c74213cd8ce0d383086d6cbf
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to