Nir Soffer has posted comments on this change.

Change subject: hsm:Use sd compat instead of qemu conf compat.
......................................................................


Patch Set 10:

(4 comments)

https://gerrit.ovirt.org/#/c/64951/10/tests/storage_hsm_test.py
File tests/storage_hsm_test.py:

Line 98
Line 99
Line 100
Line 101
Line 102
But you check that the code raises?!


Line 88:         ('0.10', '0.10', 4),
Line 89:         ('1.1', '0.10', 4),
Line 90:         ('0.10', '0.10', 3),
Line 91:     ))
Line 92:     def test_disabled_compat_raises(self, hsm_compat, qemu_config, 
sd_version):
This test check the invalid compat raises...
Line 93:         with self.fake_volume(sc.COW_FORMAT, sd_version) as vol:
Line 94:             create_conf = make_config([('irs', 'qcow2_compat', 
qemu_config)])
Line 95:             info = {"format": qemuimg.FORMAT.QCOW2, "compat": 
hsm_compat}
Line 96:             with MonkeyPatchScope([(qemuimg, 'config', create_conf),


Line 98:                 qemuimg.create(vol.volumePath, size=self.SIZE,
Line 99:                                format=qemuimg.FORMAT.QCOW2)
Line 100:                 h = FakeHSM()
Line 101:                 self.assertNotRaises(h.verify_untrusted_volume, 'sp',
Line 102:                                      vol.sdUUID, vol.imgUUID, 
vol.volUUID)
But you check that the code does not raise?!
Line 103: 
Line 104:     @permutations((
Line 105:         ('1.1', '0.10', 3),
Line 106:     ))


Line 103: 
Line 104:     @permutations((
Line 105:         ('1.1', '0.10', 3),
Line 106:     ))
Line 107:     def test_valid_compat(self, hsm_compat, qemu_config, sd_version):
This test should test valid compats...
Line 108:         with self.fake_volume(sc.COW_FORMAT, sd_version) as vol:
Line 109:             create_conf = make_config([('irs', 'qcow2_compat', 
qemu_config)])
Line 110:             info = {"format": qemuimg.FORMAT.QCOW2, "compat": 
hsm_compat}
Line 111:             with MonkeyPatchScope([(qemuimg, 'config', create_conf),


-- 
To view, visit https://gerrit.ovirt.org/64951
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4b19a99e5d9a73c011bf6d8079e3855298561b9
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to