Francesco Romani has posted comments on this change.

Change subject: [WIP] use libvirt domain xml prepared in advance
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/65182/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 219:         self._devices = Element('devices')
Line 220:         self.dom.appendChild(self._devices)
Line 221: 
Line 222:         self.appendMetadata()
Line 223:         self.doc.appendChild(self.dom)
I think this is redundant because minidom implicitely refers to the main 
Document.

Or this line fixes an issue you actually found?
Line 224: 
Line 225:     def appendClock(self):
Line 226:         """
Line 227:         Add <clock> element to domain:


-- 
To view, visit https://gerrit.ovirt.org/65182
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I469fad3ca14a6b7f4675ef5c200175053f6dd4af
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to