Martin Polednik has posted comments on this change.

Change subject: vdsm: virt: add optional container support
......................................................................


Patch Set 51:

(1 comment)

https://gerrit.ovirt.org/#/c/53820/51/lib/vdsm/containerslib.py
File lib/vdsm/containerslib.py:

PS51, Line 99: def _is_cmd(argv, reqv):
> true, but OTOH this code doesn't use the SuperVdsmCommand state at all, so 
Yeah I'm slightly torn. I understand only coupling state dependent 
functionality, but still dislike top-level (although "protected") functions 
that do share the "hidden" functionality link to some object. Not sure if it 
doesn't cross the edge of being personal dislike rather than proper improvement.


-- 
To view, visit https://gerrit.ovirt.org/53820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f
Gerrit-PatchSet: 51
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to