Nir Soffer has submitted this change and it was merged.

Change subject: jobs: Fix abort semantics

jobs: Fix abort semantics

Prior to this commit jobs.abort was treated as an synchronous operation
and if it returned successfully the caller could assume that no
operations related to the job were still running.  Unforatunately this
assumption is wrong since most underlying operations are aborted
asynchronously (ie. by sending a signal to a process).

To fix this we must adopt async abort sementics in the jobs API.  If a
job is pending and abort is called we can simply move it to aborted
state.  If the job is running we move it to aborting state, call the
abort helper (_abort) and return.  When run() finishes it will move an
aborting job to aborted.  We must not autodelete or otherwise change the
state of jobs with aborting status because it could mask the fact that a
process is still changing the host or storage.

Change-Id: I801082c50b10cf0571210d65cd3a5cec0d282a5c
Signed-off-by: Adam Litke <>
Reviewed-by: Nir Soffer <>
Continuous-Integration: Jenkins CI
M lib/vdsm/
M tests/
2 files changed, 105 insertions(+), 46 deletions(-)

  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests

To view, visit
To unsubscribe, visit

Gerrit-MessageType: merged
Gerrit-Change-Id: I801082c50b10cf0571210d65cd3a5cec0d282a5c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <>
Gerrit-Reviewer: Adam Litke <>
Gerrit-Reviewer: Dan Kenigsberg <>
Gerrit-Reviewer: Francesco Romani <>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <>
Gerrit-Reviewer: Shahar Havivi <>
Gerrit-Reviewer: gerrit-hooks <>
vdsm-patches mailing list --
To unsubscribe send an email to

Reply via email to