Francesco Romani has uploaded a new change for review.
Change subject: vm: check commands timeout only on steady state
vm: check commands timeout only on steady state
On top of the timeout errors reported from libvirt,
Vdsm marks a VM as unresponsive also if the sampling data is too old.
This usually means the VM was unresponsive to the sampling subsystem.
While the real benefit of this reporting is not completely clear,
we must keep this reporting for backward compatibility.
However, it is meaningless or harmful (false positive) to do this
check blindly, ignoring the VM state. We should skip those states:
DOWN (for obvious reasons),
MIGRATION_SOURCE (we already did that)
MIGRATION_DESTINATION (VM still on source, pointless)
POWERING_DOWN (false positives, transient state, hopefully short)
SAVING_STATE (same for migration - is migrating to disk)
WAIT_FOR_LAUNCH (hypervisor not yet started)
This leaves us the 'UP' and 'PAUSED' state, and this is what
this patch checks for.
Signed-off-by: Francesco Romani <from...@redhat.com>
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/65505/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index dc6ffe9..7ef151a 100644
@@ -4667,6 +4667,9 @@
def _setUnresponsiveIfTimeout(self, stats, statsAge):
+ # we care about timeouts only on the stady state
+ if self.lastStatus not in (vmstatus.UP, vmstatus.PAUSED):
# we don't care about decimals here
To view, visit https://gerrit.ovirt.org/65505
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-Owner: Francesco Romani <from...@redhat.com>
vdsm-patches mailing list -- email@example.com
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org