Martin Polednik has posted comments on this change.

Change subject: virt.vmdevices.core: Add Lease device
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/65465/4/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:

PS4, Line 646: # TODO: update conf from libvirt info
Do you expect some new data from libvirt?


PS4, Line 654: :param uuid id: Lease id, e.g. volume id for a volume lease, or 
vm id
             :             for a vm lease
             :         :param uuid sd_id: Storage domain uuid where lease file 
is located
             :         :param str path: Path to lease file or block device
             :         :param int offset: Offset in lease file in bytes
We don't use this doc style within device code, I prefer not mixing the styles.


-- 
To view, visit https://gerrit.ovirt.org/65465
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10fc2be51eccdd93e4c2440008f22a4ba019c466
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to