Dan Kenigsberg has submitted this change and it was merged.

Change subject: build: Replace pep8 and pyflakes with flake8
......................................................................


build: Replace pep8 and pyflakes with flake8

flake8 is an extensible and configurable tool combining pep8, pyflakes
and other plugins.

This patch replace the pep8 and pyflakes targets with single flake8
target, and remove the complex and ugly tox.sh. Everyting is configured
in a simple way in tox.ini.

Since this version includes the newers versions of pyflakes and pep8, we are
ignoring some new errors and warnings. See tox.ini for the details.

To disable ignored warnings and errors, you can:

    tox -- --ignore=''

I enabled the --show-source option by default, so now we see exactly
where is the error:

    ./tests/functional/networkTests.py:465:29: W503 line break before binary 
operator
                                <= (ARP_REQUEST_SIZE + DHCP_PACKET_SIZE),

I also enabled the --statistics option, showing:

    26    E123 closing bracket does not match indentation of opening bracket's 
line
    32    E226 missing whitespace around arithmetic operator
    45    E241 multiple spaces after ','
    31    E402 module level import not at top of file
    25    E731 do not assign a lambda expression, use a def
    24    W503 line break before binary operator

For more info see http://flake8.pycqa.org

Change-Id: Ib42430f045e4475c31cd370b4196214094c29cd1
Signed-off-by: Nir Soffer <nsof...@redhat.com>
Reviewed-on: https://gerrit.ovirt.org/65403
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <from...@redhat.com>
Reviewed-by: Edward Haas <edwa...@redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Reviewed-by: Dan Kenigsberg <dan...@redhat.com>
---
M Makefile.am
M contrib/shell_helper
M tox.ini
D tox.sh
4 files changed, 38 insertions(+), 65 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/65403
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib42430f045e4475c31cd370b4196214094c29cd1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to