Petr Horáček has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan ......................................................................
Patch Set 2: Verified-1 (1 comment) https://gerrit.ovirt.org/#/c/65231/2/tests/network/func_net_basic_test.py File tests/network/func_net_basic_test.py: Line 38: class NetworkBasicTemplate(NetFuncTestCase): Line 39: __test__ = False Line 40: Line 41: @contextmanager Line 42: def _test_detach_used_nic_from_bridge(self): test always passes (even without the fix) on dummies, it fails when nic is system nic (eth1) Line 43: with dummy_device() as nic: Line 44: NETCREATE = { Line 45: NETWORK1_NAME: {'nic': nic, 'switch': self.switch}, Line 46: NETWORK2_NAME: {'nic': nic, 'vlan': VLAN2, -- To view, visit https://gerrit.ovirt.org/65231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org