Martin Sivák has posted comments on this change. Change subject: Add new api to get the IO tune policies for all vms ......................................................................
Patch Set 11: (2 comments) https://gerrit.ovirt.org/#/c/63748/10/vdsm/virt/vm.py File vdsm/virt/vm.py: PS10, Line 2601: > we don't want anymore to build response objects in the API layer (see topic We discussed this over irc. Moving the response object construction out of here would involve catching libvirt exceptions and that won't make code nicer. We need to backport this as well so I am in favour of a followup patches instead of prepending a patch. PS10, Line 2628: Image( > the vm field is named "log", so it should be Done -- To view, visit https://gerrit.ovirt.org/63748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <[email protected]> Gerrit-Reviewer: Andrej Krejcir <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Phillip Bailey <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roman Mohr <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yanir Quinn <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
