Yaniv Bronhaim has posted comments on this change. Change subject: tests: Refine TerminationTests names ......................................................................
Patch Set 6: (4 comments) https://gerrit.ovirt.org/#/c/65326/6//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-10-13 14:32:59 +0300 Line 6: Line 7: tests: Refine TerminationTests names Line 8: Line 9: - Al the test are testing termination, there is no need to repeat s/Al/All Line 10: the class name in the test names. Line 11: - Use the tests names to describe the situation tested; terminating a Line 12: running process, or kill failure. Line 13: - Rename fake_kill to fail, describing what this function is doing. Line 7: tests: Refine TerminationTests names Line 8: Line 9: - Al the test are testing termination, there is no need to repeat Line 10: the class name in the test names. Line 11: - Use the tests names to describe the situation tested; terminating a s/names/name Line 12: running process, or kill failure. Line 13: - Rename fake_kill to fail, describing what this function is doing. Line 14: Line 15: Change-Id: Id085d7bbc65fe985454627e0958eb03d0e413b4d Line 9: - Al the test are testing termination, there is no need to repeat Line 10: the class name in the test names. Line 11: - Use the tests names to describe the situation tested; terminating a Line 12: running process, or kill failure. Line 13: - Rename fake_kill to fail, describing what this function is doing. Rameing ... describes "better" what this function does Line 14: Line 15: Change-Id: Id085d7bbc65fe985454627e0958eb03d0e413b4d https://gerrit.ovirt.org/#/c/65326/6/tests/utilsTests.py File tests/utilsTests.py: Line 101 Line 102 Line 103 Line 104 Line 105 you asked for this name iirc -- To view, visit https://gerrit.ovirt.org/65326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id085d7bbc65fe985454627e0958eb03d0e413b4d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
