Dan Kenigsberg has posted comments on this change. Change subject: storage: prepare iscsi for IPv6 targets ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/65696/6/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line 35: from vdsm import supervdsm Line 36: from vdsm.config import config Line 37: from vdsm.network.netinfo.routes import getRouteDeviceTo Line 38: from vdsm.network.errors import ConfigNetworkError Line 39: from vdsm.network.ip.address import IPv6 we try hard to avoid interdependence between storage and network subtrees. You should either move the imported function to lib/vdsm/common, or -- since what you need is so simple -- redefine what you need right here. Line 40: from vdsm.password import ProtectedPassword Line 41: from vdsm.storage import devicemapper Line 42: from vdsm.storage import misc Line 43: Line 56: Line 57: log = logging.getLogger('storage.ISCSI') Line 58: Line 59: Line 60: def getTargetString(portal, tpgt=None, iqn=None): We need to improve the code coverage of tests. Please introduce a unit test for new functions. Line 61: hostname = portal.hostname Line 62: try: Line 63: IPv6.validateAddress(hostname) Line 64: hostname = "[%s]" % hostname -- To view, visit https://gerrit.ovirt.org/65696 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e1e1ffe1c5d09b7bc3767d84a99711986eaef97 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dominik Holler <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dominik Holler <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
