Francesco Romani has posted comments on this change.

Change subject: virt: Start all VM related stuff after switching to post-copy 
migration
......................................................................


Patch Set 9: Code-Review+1

(1 comment)

changing score - it was -1 for visibility only.
Looks ok, but I need to read it carefully again before to give +2 because of 
the new synchronization steps.
Since I agree with the basic idea, provisional +1

https://gerrit.ovirt.org/#/c/63551/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 263:         else:
Line 264:             self._lastStatus = vmstatus.WAIT_FOR_LAUNCH
Line 265:         self._migrationSourceThread = migration.SourceThread(self)
Line 266:         self._kvmEnable = self.conf.get('kvmEnable', 'true')
Line 267:         self._incomingMigrationFinished = threading.Event()
> Well, what (except for the status and the corresponding event) will change 
It's the tradeoff between complicating the existing flows and adding more 
synchronization variables. I've no strong feelings however.
Line 268:         self._incoming_migration_vm_running = threading.Event()
Line 269:         self.id = self.conf['vmId']
Line 270:         self._volPrepareLock = threading.Lock()
Line 271:         self._initTimePauseCode = None


-- 
To view, visit https://gerrit.ovirt.org/63551
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8b17e58f63cbd9db09e4420871a562eaa0b3f3d
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to