Idan Shaby has posted comments on this change. Change subject: storage: add discard support for vm disks ......................................................................
Patch Set 1: I am not sure that it is a good idea. If we wouldn't have the problem with WAD vs passDiscard, maybe we could do it, but that's not the case. There's an entire logic in the engine's side regarding passing passDiscard for each disk (it's not yet on gerrit). In a nutshell, even if the disk is configured to pass discard in the engine, that doesn't mean that the engine will allow this and pass vdsm passDiscard='true'. It depends on WAD and the underlying storage support for discard and 'discard zeroes the data' (that may have been changed). Thus, making vdsm to run each vm disk with discard='unmap' by default is not possible. Please see "Wipe After Delete and Pass Discard" in the feature page for more info. -- To view, visit https://gerrit.ovirt.org/65751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I215c12260f819538e40056ec16d0b9378287ccee Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
