Francesco Romani has posted comments on this change. Change subject: vm: introduce a `monitorable' attribute ......................................................................
Patch Set 10: Verified+1 The purpose of this patch is 1. make sure VM is not misreported (actually: overzelously reported) unresponsive when starting up slowly or shutting down sloly 2. reduce misleading "XXX operation cannot run on ABC" messages ot check this, I verified again that both of the above doesn't happen if a VM starts up or shuts down slowly. Overloading one host is racy and tricky, so I tried reproducing in a more controlled environment, using just one VM, but injecting sleep()s to ensure the right sequence or events - or just slow operations. - startup: slow down domDependentInit right at the beginning. VM is still reported as responsive even if sleeps for 100s. No extra messages in the logs - shutdown: started one VM, stopped Engine, killed QEMU. Did a few tries to catch the small race here (a Down VM doesn't report responsiveness), looks ok as well. - non regression: SIGSTOP'd QEMU while Vdsm was running, VM is reported unresponsive after a timeout, and responsive again when QEMU is SIGCONT'd. -- To view, visit https://gerrit.ovirt.org/65590 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
