Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: ignore more errors in isDomainReadyForCommands ......................................................................
vm: ignore more errors in isDomainReadyForCommands Due to race on domain shutdown, and after migration end, we may receive errors from libvirt which makes the Vm.isDomainReadyForCommands() method fail with scary stacktrace. This patch makes the method cope with VIR_ERR_OPERATION_UNSUPPORTED. In the context of this method, this error can come only if the domain is shutting down, so it is safe to swallow it in this case. The real, big issue is how to properly handle the shutdown of a domain. Currently, we have to deal with domains which are partially shut down, so they are reported by libvirt and can return error (like VIR_ERR_OPERATION_UNSUPPORTED) to methods which normally succeed. One way to solve this is to make the shutdown (more) atomic: either a domain is completely operative, or it is gone. It is still to be decided if this could be done without libvirt changes. Change-Id: I89ff61e0cd3bbb977833897c250ea337c86b9f80 Backport-To: 4.0 Bug-Url: https://bugzilla.redhat.com/1382578 Signed-off-by: Francesco Romani <from...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/65131 Reviewed-by: Milan Zamazal <mzama...@redhat.com> Reviewed-by: Martin Polednik <mpoled...@redhat.com> Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M tests/vmOperationsTests.py M vdsm/virt/vm.py 2 files changed, 11 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Martin Polednik: Looks good to me, but someone else must approve Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89ff61e0cd3bbb977833897c250ea337c86b9f80 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
