From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has submitted this change and it was merged.
Change subject: build: Disable tests during build ...................................................................... build: Disable tests during build Tests are needed for development, not for building a package. This allows us to use latest and greatest development tools, which are not available in brew or koji. Since we install nose using pip, remove the build requires - we don't need now nose to build rpms. Also remove nose from the automation *.packages files, since we install it from pip. Finally remove the nose check from configure, since configure is run during the build, and we cannot require nose at this point. We are checking nose when running the tests. We still install python 3 nose using the distribution packages, since it is new enough, and mixing pip and pip3 on same machine does not work well. Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516 Signed-off-by: Nir Soffer <nsof...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/63966 Reviewed-by: Edward Haas <edwa...@redhat.com> Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M automation/check-merged.packages.el7 M automation/check-merged.packages.fc24 M automation/check-patch.packages.el7 M automation/check-patch.packages.fc24 M configure.ac M vdsm.spec.in 6 files changed, 0 insertions(+), 14 deletions(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63966 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
