From Yaniv Bronhaim <[email protected]>: Yaniv Bronhaim has posted comments on this change.
Change subject: client: add default value for port parameter ...................................................................... Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/67069/1/lib/vdsm/client.py File lib/vdsm/client.py: Line 96: from yajsonrpc import stompreactor Line 97: import yajsonrpc Line 98: Line 99: Line 100: def connect(host, port=54321, use_tls=True, timeout=60): > I think the client library should be part of the api package, but for now i Dan won't like it probably. lets raise it in the meeting Line 101: try: Line 102: client = stompreactor.SimpleClient(host, port, use_tls) Line 103: except Exception as e: Line 104: raise ClientError("connect", None, e) -- To view, visit https://gerrit.ovirt.org/67069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id28256a3baa0f57478e7670ff756692015f27303 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
