From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has submitted this change and it was merged.
Change subject: protocoldetector: Handle socket.error in handle_accept ...................................................................... protocoldetector: Handle socket.error in handle_accept If socket.error is not handled in handle_accept, asyncore assumes that the error is related to the listen socket and close it. However, a socket.error may be raised by client socket if the remote side closed the socket immediately, for example, during port scanning. This is a regression introduced by commit b25dbdcce417 (Have the protocol detector use the Reactor), replacing the previous implementation with "better" asyncore base solution. This patch fixes this issue by handling socket.error in handle_accept, closing the client socket. Change-Id: I10a41f6d3f07296ad42fbc92dbf66f4ec85530e0 Bug-Url: https://bugzilla.redhat.com/1326940 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/67056 Continuous-Integration: Jenkins CI Reviewed-by: Piotr Kliczewski <[email protected]> --- M lib/vdsm/protocoldetector.py 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Nir Soffer: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10a41f6d3f07296ad42fbc92dbf66f4ec85530e0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
