From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has submitted this change and it was merged.
Change subject: domain_descriptor: correctly check if element is present ...................................................................... domain_descriptor: correctly check if element is present As per Python ETree documentation: Caution: Elements with no subelements will test as False. This behavior will change in future versions. Use specific len(elem) or elem is None test instead. This caused the expression to evaluate to None instead of VM's memory, overwriting the VM's conf with invalid value. Change-Id: I2783abfe3b527f5fc6d5575239e5cb571f9f1682 Bug-Url: https://bugzilla.redhat.com/1396816 Signed-off-by: Martin Polednik <mpoled...@redhat.com> --- M vdsm/virt/domain_descriptor.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/67141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2783abfe3b527f5fc6d5575239e5cb571f9f1682 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
