From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: after_vm_destroy.py: migrate to jsonrpc ...................................................................... Patch Set 10: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/62383/10/vdsm_hooks/vhostmd/after_vm_destroy.py File vdsm_hooks/vhostmd/after_vm_destroy.py: PS10, Line 30: use_tls=True this means that the hook would fail if localhost has tls disabled. you may not want connect() to have the fancy logic, but it should sit somewhere. -- To view, visit https://gerrit.ovirt.org/62383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f3fa6479dde2c4a1298d0ae167d888d9f7e020a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
