From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: Remove the usage of  clientIF from GlusterApi
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/67660/1/lib/vdsm/rpc/bindingxmlrpc.py
File lib/vdsm/rpc/bindingxmlrpc.py:

Line 1210:                 (self.devicesGetVisibility, 'getDevicesVisibility'),
Line 1211:                 (self.sdm_create_volume, 'sdm_create_volume'))
Line 1212: 
Line 1213: 
Line 1214: def _wrap_api_method(f, cif):
this change should sit in a tny separate patch. sorry for not being clear about 
it.
Line 1215:     def wrapper(*args, **kwargs):
Line 1216:         start_time = utils.monotonic_time()
Line 1217:         res = {}
Line 1218:         try:


https://gerrit.ovirt.org/#/c/67660/1/vdsm/gluster/apiwrapper.py
File vdsm/gluster/apiwrapper.py:

Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: from __future__ import absolute_import
Line 21: 
Line 22: from vdsm.gluster.api import GlusterApi, META_VOLUME
seems more related to the next patch in the series.
Line 23: 
Line 24: 
Line 25: class GlusterApiBase(object):
Line 26:     ctorArgs = []


-- 
To view, visit https://gerrit.ovirt.org/67660
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id08bb1ff6d988aa06aca993378f3eb96fd7270a2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to