From Yaniv Bronhaim <[email protected]>: Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-client: Make executable in the source ...................................................................... Patch Set 1: (2 comments) I recall to ask for verifying that the file is indeed being installed with the right permissions... this chmod can be done also as part of the spec https://gerrit.ovirt.org/#/c/69066/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-12-24 19:09:31 +0200 Line 6: Line 7: vdsm-client: Make executable in the source Line 8: Line 9: Having an executable script we can test it easilty without installing it: don't pass 80 chars in line please Line 10: Line 11: $ PYTHONPATH=lib static/usr/bin/vdsm-client -h Line 12: usage: vdsm-client [-h] [-a HOST] [-p PORT] [--unsecure] [--timeout TIMEOUT] Line 13: [-f FILE] Line 10: Line 11: $ PYTHONPATH=lib static/usr/bin/vdsm-client -h Line 12: usage: vdsm-client [-h] [-a HOST] [-p PORT] [--unsecure] [--timeout TIMEOUT] Line 13: [-f FILE] Line 14: namespace method [method_args [method_args ...]] use spaces Line 15: ... Line 16: Line 17: Change-Id: I96bd3e933b65431f72fa1a21901e05b1d7c5b1ea -- To view, visit https://gerrit.ovirt.org/69066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96bd3e933b65431f72fa1a21901e05b1d7c5b1ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
