From Yaniv Bronhaim <ybron...@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding grub2-tool requirement which host-deploy requires
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/69462/2//COMMIT_MSG
Commit Message:

Line 7: Adding grub2-tool requirement which host-deploy requires
Line 8: 
Line 9: In some environments this package is not installed by default, and
Line 10: is needed to allow running:
Line 11: "/sbin/grubby --update-kernel DEFAULT" which host-deploy uses.
> If host-deploy is using it, why it does not install the package?
host-deploy installs vdsm (and other ovirt related packages) on the host and 
assume the host is ready for the rest it does.. problem. its either do it in 
host-deploy using vdsm-tool which will lead us to require that or just require 
it and leave it as is. do you see another alternative?
Line 12: 
Line 13: Change-Id: Ibb3b3b525df25a1affc1583d573409cdb28b31bd


-- 
To view, visit https://gerrit.ovirt.org/69462
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb3b3b525df25a1affc1583d573409cdb28b31bd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to