From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Check changed modules in check-patch ...................................................................... Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/69450/8/automation/check-patch.sh File automation/check-patch.sh: Line 16: # Check python files changed in this patch Line 17: modules=$(git diff-tree --no-commit-id --name-only -r HEAD | egrep '\.py$') Line 18: if [ -n "$modules" ]; then Line 19: PYTHONPATH=vdsm:lib pylint --errors-only $modules Line 20: fi > We can move this to the makefile, maybe make pylint-diff yes, that would be beneficial to test my current git diff before posting it. Line 21: Line 22: debuginfo-install -y python Line 23: Line 24: TIMEOUT=600 make check NOSE_WITH_COVERAGE=1 NOSE_COVER_PACKAGE="$PWD/vdsm,$PWD/lib" -- To view, visit https://gerrit.ovirt.org/69450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia458909a300c8555a84f3d7f1f8a410c0856e444 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
