From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: tests: network: dhcp: wait for dnsmasq ...................................................................... Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/69746/1/tests/network/dhcp.py File tests/network/dhcp.py: Line 79: (''.join(self.proc.stderr), ' '.join(command))) Line 80: Line 81: def stop(self): Line 82: self.proc.kill() Line 83: self.proc.wait() > do we trust dnsmasq that if won't block us forever or should we use timeout I do not afraid of that. one line below we already wait indefinitely for it to close its stderr. We just add an orderly collection of its returncode. Line 84: logging.debug(''.join(self.proc.stderr)) Line 85: Line 86: Line 87: class ProcessCannotBeKilled(Exception): -- To view, visit https://gerrit.ovirt.org/69746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76c8c0d9f89e72a21bd9b0aaa658c7659020a5fa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgold...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
