From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: py3: make toolBondingTests pass ...................................................................... Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65666/1/lib/vdsm/network/netinfo/bonding.py File lib/vdsm/network/netinfo/bonding.py: Line 258: Line 259: Line 260: def _bond_opts_name2numeric_scan(opt_path): Line 261: vals = {} Line 262: with open(opt_path, 'w') as opt_file: > Also this open the file in text more instead of binary in python 3. Better right! thanks! Line 263: for numeric_val in range(32): Line 264: name, numeric = _bond_opts_name2numeric_getval(opt_path, opt_file, Line 265: numeric_val) Line 266: if name is None: -- To view, visit https://gerrit.ovirt.org/65666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4487b787c3a14ca9508847572622f431f1188e7f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <leon.ot...@gmail.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
