ShaoHe Feng has posted comments on this change. Change subject: vdsm: use default libvirt event handler impl ......................................................................
Patch Set 4: (1 inline comment) .................................................... File vdsm/libvirtvm.py Line 63: "Shutdown", Line 64: "PM-Suspended") Line 65: Line 66: Line 67: def event_to_string(event): Code Style of Vdsm http://wiki.ovirt.org/wiki/Vdsm_Developers CamelCase just for class name rule. no rule for function. Line 68: return _EVENT_STRINGS[event] Line 69: Line 70: Line 71: class VmStatsThread(utils.AdvancedStatsThread): -- To view, visit http://gerrit.ovirt.org/5015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d6b1f856b5a5b216d2dddf629c5ec80e8b7e7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
