From Yaniv Bronhaim <[email protected]>: Yaniv Bronhaim has posted comments on this change.
Change subject: JsonRpcClient: add subcribe and unsubscribe ...................................................................... Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/70110/8/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 381: self._finalizeCtx(ctx) Line 382: Line 383: def subscribe(self, queue_name): Line 384: subscription = self._transport.subscribe(queue_name) Line 385: return subscription why not just return self._transport.subscribe(queue_name) ? but instead of forward functions that doesn't add any logic why not to expose transport and directly call client.transport.subscribe when needed? Line 386: Line 387: def unsubscribe(self, sub): Line 388: self._transport.unsubscribe(sub) Line 389: -- To view, visit https://gerrit.ovirt.org/70110 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e35b82762a101cc0034995b7c0e506ec0a803d8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
