From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: tests: actually set existing ioTune settings ...................................................................... vm: tests: actually set existing ioTune settings Reading the source code in vm.py _and_ vmdevices/storage.py reveals that the storage code was using and storing the ioTune settings under self.specParams, not under self.conf['specParams']. This is fine, but the test code feed the storage device with pre-existing ioTune settings using self.conf['specParams']. This is misleading in the best case, wrong in the worst case. This patch actually sets the old ioTune settings using the right field - specParams. Doing so we discover that the code is indeed broken if it has to update the existing ioTune settings - exactly because the testcase never covered such scenario. For the (short) time being, we mark the test broken until we fix the code. Change-Id: I5e266d0a8a5378d4e02b70289999d7eae0fb6ba9 Signed-off-by: Francesco Romani <[email protected]> --- M tests/vm_test.py 1 file changed, 16 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/70912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e266d0a8a5378d4e02b70289999d7eae0fb6ba9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
