From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: virt: Run job completed callback only for migrations ...................................................................... Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/72329/4//COMMIT_MSG Commit Message: PS4, Line 11: host migration jobs clasically, callbacks are given a void* argument, that can be filled by the original caller, and serves as its identifier. Would it not be a cleaner, safer solution here? (/me did not read the code, just wondering) -- To view, visit https://gerrit.ovirt.org/72329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I066906f4898d188ceac50101df6bf20adfa0ff89 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
