From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: ngn: provide release according with os-release ...................................................................... Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/72829/1/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 82: NORMAL = 0 Line 83: HIGH = 19 Line 84: Line 85: Line 86: def isNextGenNode(): is there any need to place it outside of osversion module? I prefer to keep things private, unless they are universally needed. please use pep8-compliate function_names for new functions. Line 87: """ Line 88: Return: Line 89: True if it's oVirt Node Next or RHV Node Line 90: """ -- To view, visit https://gerrit.ovirt.org/72829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f35d8f2221c07a38e9d75b96324315266b0d51a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
