From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: hostdev: when calculating hash, skip over devices are gone ...................................................................... Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/73460/4/lib/vdsm/hostdev.py File lib/vdsm/hostdev.py: PS4, Line 131: libvirt.libvirtError: this is a very general error (e.g. restart of libvirtd would cause this). Can you narrow down the expected error that you are ignoring? when would you stop reporting the now-gone device? -- To view, visit https://gerrit.ovirt.org/73460 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86d594c4a9c5a16739a73a3ad07487d096d0f991 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
