From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: vmdevices: use default if no displayNetwork ...................................................................... Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/75134/2/lib/vdsm/virt/vmdevices/graphics.py File lib/vdsm/virt/vmdevices/graphics.py: Line 235: # the device is defaulted to the network name (i.e. northbound port). Line 236: device = (nets[network].get('iface', network) Line 237: if network in nets else network) Line 238: ip, _, _, _ = net_api.ip_addrs_info(device) Line 239: # TODO: is this still an option with on-demand created networks? > I don't understand this TODO. maybe I do. please rebase on top of https://gerrit.ovirt.org/#/c/75150/ Line 240: except (libvirt.libvirtError, KeyError, IndexError): Line 241: ip = config.get('addresses', 'guests_gateway_ip') Line 242: finally: Line 243: if ip == '': -- To view, visit https://gerrit.ovirt.org/75134 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb016d002b507d6c9b31f5f628ba4d8fa3543a12 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horacek <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
