From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: dmidecode: don't assume dmidecode output is ok ...................................................................... Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/76671/1/lib/vdsm/dmidecodeUtil.py File lib/vdsm/dmidecodeUtil.py: Line 29: # value for each key. Keys in d that their value is a dictionary will be Line 30: # ignored because those keys define a lable for the sub dictionary Line 31: # (and those keys are irrelevant for us in dmidecode output) Line 32: def __leafDict(d): Line 33: ret = {} why do you do it in such a low location? why do you do it at all? When does dmidecode fail, and how? can you please elaborate in the commit message? Line 34: try: Line 35: for k, v in d.iteritems(): Line 36: if isinstance(v, dict): Line 37: ret.update(__leafDict(v)) -- To view, visit https://gerrit.ovirt.org/76671 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd4cc123bd1c20a5bdac6d9befa60bc9783263c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
