From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: logUtils: Move logUtils module to vdsm.common ...................................................................... Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/76919/8/static/etc/vdsm/logger.conf.in File static/etc/vdsm/logger.conf.in: Line 60: formatter=sysform Line 61: args=('/dev/log', handlers.SysLogHandler.LOG_USER) Line 62: Line 63: [handler_logfile] Line 64: class=vdsm.common.logutils.UserGroupEnforcingHandler > Sadly, this two little ones cost me 1h figuring out why the services crashe this is actually a big problem. if someone editted this file, it would not be replaced on upgrade, and they would be left with a reference to a non-existing object. we're kinda doomed. either keep vdsm.logUtils refering the new location, or provide a little 'sed' fixing the log file on upgrade. Line 65: args=('@VDSMUSER@', '@VDSMGROUP@', '@VDSMLOGDIR@/vdsm.log',) Line 66: filters=storage.misc.TracebackRepeatFilter Line 67: level=DEBUG Line 68: formatter=long -- To view, visit https://gerrit.ovirt.org/76919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic642205e3d5515acfeb607bb5dcad24f699d286f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
