From Yaniv Bronhaim <ybron...@redhat.com>: Yaniv Bronhaim has posted comments on this change.
Change subject: http: extract request handler ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/77388/1/lib/vdsm/rpc/http.py File lib/vdsm/rpc/http.py: Line 76: self._thread.join() Line 77: return {'status': doneCode} Line 78: Line 79: Line 80: class RequestHandler(BaseHTTPRequestHandler): lets be more specific here please - this is ImageRequestHandler or whatever this is - but its not a generic requestHandler at all Line 81: Line 82: # Timeout for the request socket Line 83: timeout = 60 Line 84: log = logging.getLogger("rpc.http.RequestHandler") -- To view, visit https://gerrit.ovirt.org/77388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04b55e31e6ea791b4ddc156cdd39aa16aa030822 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
