From Yaniv Bronhaim <ybron...@redhat.com>: Yaniv Bronhaim has posted comments on this change.
Change subject: lib: move API ...................................................................... Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/77571/1/tests/check_imports.py File tests/check_imports.py: Line 34: """ Line 35: Yields fully qualified modules names in the vdsm package. Line 36: """ Line 37: expected_to_fail = { Line 38: "vdsm.API", > Once vdsm.virt is moved to lib we can remove modules from here. not sure if doing that its the best direction to "organize" things... but its up to maintainers to agree Line 39: "vdsm.clientIF", Line 40: "vdsm.rpc.Bridge", Line 41: "vdsm.rpc.http", Line 42: } -- To view, visit https://gerrit.ovirt.org/77571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8eeff74f4269d886d557a912070b54c1d9d642ff Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
