From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: spec: vdsm-network onetime services restart on upgrade ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/77766/1/vdsm.spec.in File vdsm.spec.in: Line 814: # VDSM upgrade section Line 815: if [ "$1" -gt 1 ]; then Line 816: # vdsm-network onetime service needs to stopped on upgrades, Line 817: # allowing it to be retriggered by its dependents. Line 818: /bin/systemctl stop vdsm-network >/dev/null 2>&1 || : vdsm is a dependency of vdsm-network, so I believe this commands stops it. this means that later, in %postun, it would be found as stopped, and would not be restarted. If we have to do this here, we must somehow remember whether vdsm was running, and use this knowledge in %postun. That sounds very difficult to do without a time machine, since vdsmd_start_required is calculated regardless of this knowledge. I don't know if it is possible to solve within the spec; we may have to pass "vdsm-network-start-required" to the vdsmd service. Line 819: fi Line 820: exit 0 Line 821: Line 822: %preun -- To view, visit https://gerrit.ovirt.org/77766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f9369dfd4dd6c4178b43fa194dc0272c7820cf4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michael Burman <mbur...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
