From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: vm: create a vnic with vhostuser backend ...................................................................... Patch Set 31: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/74327/31/lib/vdsm/virt/vmdevices/network.py File lib/vdsm/virt/vmdevices/network.py: Line 303: detach_detachable(self.hostdev) Line 304: else: Line 305: bridge_info = supervdsm.getProxy().ovs_bridge(self.network) Line 306: if bridge_info and bridge_info['dpdk_enabled']: Line 307: self._is_vhostuser = True this is not called during recovery flow. We should either persist this in conf, or pass it to __init__ during recovery, or recalculate during deardown+getXML. Line 308: self._create_vhost_port(bridge_info['name']) Line 309: Line 310: def teardown(self): Line 311: if self.is_hostdevice: -- To view, visit https://gerrit.ovirt.org/74327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie81cf52f17ffe01713dd6502d68c4b17c64e5335 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
