From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78925 )
Change subject: stomp: set default heartbeat values and add grace period ...................................................................... stomp: set default heartbeat values and add grace period default incoming heartbeat used to be 5 seconds but was never checked. In an actual system the heartbeat should be greater, since CPU and network spikes affect the server communication and don't indicate there is a real communication problem. Also, in order to make sure incoming heartbeats are received and we won't close the socket before getting them, we add grace period for incoming heartbeats and reduce the outgoing heartbeats interval in order to make sure the outgoing heartbeats are received in server side. By default, number of retries after timeout is 1 to ensure fast recovery. Change-Id: I0e8c4f2fef9083521dcf2da12cf1f9db84b75492 Signed-off-by: Irit Goihman <igoih...@redhat.com> Bug-Url: https://bugzilla.redhat.com/1376843 --- M lib/vdsm/client.py M lib/yajsonrpc/stomp.py M lib/yajsonrpc/stompreactor.py M tests/stompasyncclient_test.py 4 files changed, 39 insertions(+), 14 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Irit Goihman: Verified -- To view, visit https://gerrit.ovirt.org/78925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e8c4f2fef9083521dcf2da12cf1f9db84b75492 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
