From Yaniv Bronhaim <[email protected]>: Yaniv Bronhaim has posted comments on this change.
Change subject: Move fencing code to host/fencing.py ...................................................................... Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/78927/2/lib/vdsm/host/fencing.py File lib/vdsm/host/fencing.py: Line 48: # This global var will hold HSM instance or another provider that can retrieve Host Lease Status Line 49: # Therefore set_storage_monitor should be called before and set there a class that implements getHostLeaseStatus Line 50: # function. Line 51: _storageMonitor = None Line 52: > Why not to have a Fencing class? We could got rid of storage_monitor global why would we want class? its a module Line 53: Line 54: def set_storage_monitor(monitor): Line 55: global _storageMonitor Line 56: _storageMonitor = monitor -- To view, visit https://gerrit.ovirt.org/78927 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73763a7a784b17bd2b8bd04a22c0f5a5ec4ab1b6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
