From Yaniv Bronhaim <ybron...@redhat.com>: Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: fix AsyncDispatcher next_check_interval ...................................................................... Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/79384/4/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 413: self._incoming_heartbeat_in_milis == 0: Line 414: return None Line 415: Line 416: if self._incoming_heartbeat_in_milis and \ Line 417: self._incoming_heartbeat_expiration_interval() < 0: > We need timeouts, and instead of having a proper solution, we hacked this n from what I understand the complexity is redundant in this code. we have a mess of implementations that part of them Im quite sure we don't use any more. My problem is that I just can't map the dependencies between objects here each time I try to go over this code :| maybe its only be. but its exhausting I'm not sure how urgent is the heartbeat feature - if it is for 4.1, lets hack this craziness again. but we can't keep doing that.. Do we still need the protocol detector? How many kind of "Dispatchers" we need? can we have only one Dispatcher implantation? It still kills me why StompAdapterImpl and AsyncClient are not called frame handlers? why those can't be kind of dispatchers? all this hierarchy must be reconsidered and fixed. Its long run changes that we can do in those areas.. I think we can rethink and make it much nicer... depends on priorities and desire Line 418: self.handle_timeout() Line 419: return None Line 420: Line 421: if self._outgoing_heartbeat_in_milis: -- To view, visit https://gerrit.ovirt.org/79384 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e7fe82f80535ff851eaf909de194419511154ba Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
