From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: net: move API.updateTimestamp to net.connectivity.confirm
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/79299/4/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

PS4, Line 288: cancel_rollback
> The connectivity module is responsible of checking connectivity, it has no 
ok, I'm shelving my grand plans for now. removing P_CLIENT_LOG out of 
vdsm.constants is more important to me now.


Line 285:     netswitch.configurator.ovs_remove_port(bridge, port)
Line 286: 
Line 287: 
Line 288: def cancel_rollback():
Line 289:     touch_file(connectivity.P_VDSM_CLIENT_LOG)
> How abut pushing in the implementation to the connectivity module?
Done


-- 
To view, visit https://gerrit.ovirt.org/79299
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If42316ac6ecd694e398534e3e87b915aeb4f1f38
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to