From Yaniv Bronhaim <ybron...@redhat.com>:

Yaniv Bronhaim has posted comments on this change.

Change subject: ssl: handle handshake errors
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/79668/1/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:

Line 187:                 self._handshake(dispatcher)
Line 188:             except socket.error:
Line 189:                 self.log.error("Handshake failed")
Line 190:                 dispatcher.socket.close()
Line 191:                 return
seems like _handshake itself takes care of exceptions.. if you need to handle 
socker.error somewhere its there and not here
Line 192:         else:
Line 193:             if config.getboolean('vars', 'verify_client_cert'):
Line 194:                 if not 
self._verify_host(dispatcher.socket.getpeercert(),
Line 195:                                          
dispatcher.socket.getpeername()[0]):


-- 
To view, visit https://gerrit.ovirt.org/79668
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99cfa35e608f429640455c35495be1783854e3da
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to