From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: hooking: move to lib
......................................................................


Patch Set 7:

(2 comments)

https://gerrit.ovirt.org/#/c/79638/7/tests/run_tests_local.sh.in
File tests/run_tests_local.sh.in:

Line 23
Line 24
Line 25
Line 26
Line 27
why is `client` related and removed?


https://gerrit.ovirt.org/#/c/79638/7/vdsm.spec.in
File vdsm.spec.in:

PS7, Line 732: PYLIBDIR
> I do not like it but if we want to have this module in lib/vdsm I do not se
I'd keep it completely out of the constants.py junkyard. Howe about taking

 os.path.dirname(vdsm.hook.__file__)

whereever the path is needed? (frankly, I think that there's only a single 
user, in hooks.py)


-- 
To view, visit https://gerrit.ovirt.org/79638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2f1581d75cfb33868af41d1b116f56af89801a5
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to