From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has uploaded a new change for review.

Change subject: move constants.SUPPORTED_BLOCKSIZE to its sole user
......................................................................

move constants.SUPPORTED_BLOCKSIZE to its sole user

Change-Id: I2845bd782b2641accfa1b3bd27a6a47c5723ae06
Signed-off-by: Dan Kenigsberg <dan...@redhat.com>
---
M lib/vdsm/constants.py.in
M lib/vdsm/storage/lvm.py
2 files changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/79731/1

diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in
index 2d16d31..68c8b7a 100644
--- a/lib/vdsm/constants.py.in
+++ b/lib/vdsm/constants.py.in
@@ -55,7 +55,6 @@
 # This is the domain version translation list
 # DO NOT CHANGE OLD VALUES ONLY APPEND
 DOMAIN_VERSIONS = (0, 2, 3, 4)
-SUPPORTED_BLOCKSIZE = (512,)
 
 # This contains the domains versions that this VDSM
 # accepts currently its all of the version but in the
diff --git a/lib/vdsm/storage/lvm.py b/lib/vdsm/storage/lvm.py
index 3421d20..7d26d9c 100644
--- a/lib/vdsm/storage/lvm.py
+++ b/lib/vdsm/storage/lvm.py
@@ -71,6 +71,8 @@
 LV_ATTR = namedtuple("LV_ATTR", LV_ATTR_BITS)
 Stub = namedtuple("Stub", "name, stale")
 
+SUPPORTED_BLOCKSIZE = (512,)
+
 
 class Unreadable(Stub):
     __slots__ = ()
@@ -1095,7 +1097,7 @@
         pvBlkSize = _getpvblksize(pv)
         logPvBlkSize, phyPvBlkSize = pvBlkSize
 
-        if logPvBlkSize not in constants.SUPPORTED_BLOCKSIZE:
+        if logPvBlkSize not in SUPPORTED_BLOCKSIZE:
             raise se.DeviceBlockSizeError(pvBlkSize)
 
         if phyPvBlkSize < logPvBlkSize:


-- 
To view, visit https://gerrit.ovirt.org/79731
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2845bd782b2641accfa1b3bd27a6a47c5723ae06
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com>
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to